Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript Examples to vue-testing-library #1463

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

aburdiss
Copy link
Contributor

On the React Testing Library Docs, there are TypeScript examples, but these do not exist on most other pages.

I believe that it's useful for TypeScript examples to exist on other pages as well, especially examples, and even if they're extremely similar to the JavaScript examples, because this makes it more accessible to newer developers.

Disclosure: I'm newer to VueJS and TypeScript (coming from JS/React), and have been reading the docs myself to get this set up on my end, so if anyone notices better ways of handling these examples I'm not attached to the code inside.

Copy link

netlify bot commented Dec 24, 2024

Deploy Preview for testing-library ready!

Name Link
🔨 Latest commit 16f3896
🔍 Latest deploy log https://app.netlify.com/sites/testing-library/deploys/676ab95929bcae00083806f5
😎 Deploy Preview https://deploy-preview-1463--testing-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me 👍
I'll leave this open a while longer so others can also review, otherwise i'll merge this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants