-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sm dg style header navigation #62
Conversation
Visit the preview URL for this PR (updated for commit 465c131): https://tcl-68-smart-shopping-list--pr62-sm-dg-style-header-n-iz0izrev.web.app (expires Fri, 12 Apr 2024 22:44:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8cb5d089a99ba9972009993f4dd31796b0cbda84 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking great! Cant' wait to see the other styling you guys did integrated together with this batch.
Thought: We'll need to incorporate the text-off-black into our end of the styling for consistency. It's certainly nicer than black black.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
This PR adds styling to our header and navbar at the bottom of the app, according to our prototype / mockup styling.
Related Issue
Closes Issue #57
Acceptance Criteria
Navigation Bar
Buttons
: Navigation BarHeader text
: Signed in AsButton
: Sign OutType of Changes
enhancement
Updates
Before
After
Testing Steps / QA Criteria
Note: There is spacing added to the 'Signed in as' and button next to it on our other PR (home page styling) as well as the background color changed to eggshell on the body as well (those changes not represented in these screenshots).