-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List and Manage List styling #63
Conversation
…or to palette, changed urgency return 'Kind of soon' to 'Kinda soon'
…ting in List and ManageList views
… code from AddItem, refactored grid templates for tiny screen size into one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Praise: These changes look great, I noticed a lot of nice details you all added in your grids with padding and margins that really reformatted the list items into a much better situation for the user.
non-blocking concern for the future: As we merge these remaining PRs prior to our demo, we might need to adjust everything to make it look cohesive, then we'll need to do a bit of accessibility review / check the contrast like Andrea did a little bit ago.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Praise: It looks pehnomal! You guys clearly put a lot of effort into this, it shows! Our app is looking coherent.
Nit: The background color for the input in the ManageList to share a list is pale-green, but the input boxes in the List view are not, I think we should make all of our forms the same if we can. Personally I think the white background looks cleaner. Shane and I set ours to eggshell for now (because not setting a background color will have it default to white in light mode and black in dark mode, which looked funny.) We could change all of them to a basic white?
Oops, yes I meant to change that last form input background color. I can set everything to basic white (#FFF) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, this is looking great team!
Visit the preview URL for this PR (updated for commit bd001b7): https://tcl-68-smart-shopping-list--pr63-ap-et-styling-br0gtuj8.web.app (expires Sun, 14 Apr 2024 00:34:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 8cb5d089a99ba9972009993f4dd31796b0cbda84 |
Description
Related Issue
Closes #58
Closes #59
Acceptance Criteria
The following elements should be styled on our
List
page according to our prototype:Header
: List nameLabel
: Search for an item (rename to Filter?)Input Search Box
: Search for an item by nameButton
: ResetLabel
: Add new itemInput Text Box
: Item NameInput Select Dropdown
: Next Purchase DateButton
: Add itemList Items
: Items in the user's listButton
: Select a listHeader
: List is currently emptyHeader
: You haven't selected a listThe following elements from our
Manage List
page should be styled according to our prototype:Header
: List name- [ ](We opted to exclude this design element.)Header
: Manage ListLabel
: Share ListInput Text Box
: Enter Recipient's Email AddressButton
: Send Invite!Button
: Delete ListType of Changes
enhancement
Updates
Before
List view - no list selected
Manage List view - no list selected
List view - empty list
List view - populated list
Managed List view - list selected
After
List view - no list selected
Manage List view - no list selected (should look the same as List view)
List view - empty list
List view - populated list
Manage List view - list selected
Testing Steps / QA Criteria
ap-et-styling
locally