-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue#47: Install and configure sass npm package #50
Conversation
Visit the preview URL for this PR (updated for commit ce31176): https://tcl-77-smart-shopping-list--pr50-fz-clean-branch-lrlnktis.web.app (expires Mon, 07 Oct 2024 04:33:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw you wrote an example inside the acceptance criteria. But approving for now in the meantime!
@@ -34,6 +34,7 @@ | |||
"jsdom": "^24.1.1", | |||
"lint-staged": "^15.2.9", | |||
"prettier": "^3.3.3", | |||
"sass-embedded": "^1.79.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, interesting. The error doesn't show up on my end so not sure what's up. Did you try to see if it works in the preview? If it works there and doesn't work when you checkout the branch, maybe try deleting the node modules and do npm ci
?
Thanks for doing this! I used the preview link to just see it was all still working and looking at it and it was well done. I really appreciate the example on the |
Good to know that it was still working in preview 😄 Thanks for the feedback! Yeah, I do think this will work great together with the bootstrap components. |
Description
We need to add SCSS support to the project to improve the maintainability and organization of styles across components. SCSS offers enhanced styling capabilities, such as variables, nesting, and mixins, which will help make the code more modular and scalable.
Related Issue
Closes #47
Acceptance Criteria
npm install -g sass
.Type of Changes
enhancement
feature
Notes
_variables.scss
is added understyles
folder with some placeholder values for colours.Related document resource