Bb/about page carousel design #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit a724ecb): https://tcl-77-smart-shopping-list--pr66-bb-about-page-carous-fbc1ydci.web.app (expires Thu, 17 Oct 2024 04:33:51 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: b77df24030dca7d8b6561cb24957d2273c5e9d72 |
bbland1
added a commit
that referenced
this pull request
Oct 17, 2024
* moving navbar to header and getting background color * working on the unauth header * getting the hamburger to show on the small screen and the links to be correct color * spacing the navigation links on expanded view * fixing the hamburger being bumped down when trying mobile * getting the brand name to be at the top like design * getting the hamburger and title on same page when on iphone SE * making sure the navbar toggler icon can be seen * making sure nav bar close on mobile clicks * Bb/about page carousel design (#66) * adding the borders and positioning the text areas on the page * figuring out some spacing on thank you & creators with theme-colors set * getting the lin icons to space evenly and the same on all of them * fixing the margins of the page for the whole about page * getting the base of the carousel with image working * card title on carousel card * when merged the about page into header branch all the buttons broke were just beige not sure why but fixed * changing color of svg icons * the creators and thank you boxes are equal size now * fixed media queries for mobile size to make sure button looked okay * switch button color and bg for clearer on small screens and more consistency * moving sign out button outside of menu hamburger * fixing a change to the layout width didn't see got changed * added about to navbar and removed button like the design * fix button size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an example of how to fill this template out, see this Pull Request.
Description
Related Issue
Acceptance Criteria
Type of Changes
Use one or more labels to help your team understand the nature of the change(s) you’re proposing. E.g.,
bug fixorenhancementare common ones.Updates
Before
After
Testing Steps / QA Criteria