-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapting cppExamples for Windows build #178
Conversation
morteham
commented
Nov 15, 2024
- Avoid conflict with definition of _CONCAT in xatomic.h
- Set CXX flags for MSVC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Could you add a note in the C++ "getting started" helper (docs/vCurrent/getting_started_cpp.md
) mentioning anything people need to take into account when using the C++ wrapper?
It would probably also be nice to add a workflow step to the unittests workflow equivalent to Run cppExamples on Linux/macOS
that just builds and runs the examples on windows so that we can be sure they stay fixed in the future :)
Updated docs and |
It looks like the Ubuntu GitHub runner doesn't have ninja installed. I can see from the I tried pushing a fix now, I'll merge if it works, otherwise I'll probably just need to tweak a bit for the ninja installation to work properly (ensure stuff is correctly added to PATH etc.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice stuff, we ballin'