[FX-121] Add support for Safari with clip-path #150
Conversation
denieler
requested review from
a team,
MilosMosovsky,
vedrani,
bytasv and
havenchyk
|
Successfully deployed demo at https://picasso.toptal.net/fix-clip-path-support |
components/Avatar/styles.ts
Outdated
| @@ -36,7 +36,8 @@ export default ({ palette }: Theme) => | |||
| fontSize: '4.5rem' | |||
| }, | |||
| clippedCorner: { | |||
| clipPath: getClipPathCornerMask('0.3em') | |||
| clipPath: getClipPathCornerMask('0.3em'), | |||
| '-webkit-clip-path': getClipPathCornerMask('0.3em') | |||
There was a problem hiding this comment.
Strange, doesn't JSS has auto prefixing? Maybe we could enable it somehow in order to avoid such cases?
There was a problem hiding this comment.
We already discussed that with daniel, I also believe we shouldn't do manual prefixing, so far I've found https://cssinjs.org/jss-plugin-vendor-prefixer but still it's more than strange .... I think MUI needs to have prefixing enabled and maybe we are just missing something ...
There was a problem hiding this comment.
Can we add that plugin to webpack config in storybook?
|
As daniel found out @vedrani @bytasv cssinjs/css-vendor#74 :D :D |
|
Yes, I was just reading about it. Crazy |
|
That's just horrible in 2019... JSS |
|
Successfully deployed demo at https://picasso.toptal.net/fix-clip-path-support |
|
Successfully deployed demo at https://picasso.toptal.net/fix-clip-path-support |
| Additional notes: | ||
| * The shape of clipped corner has a fallback for <=IE11, Edge to just a rectangle | ||
| ` | ||
| ) |
There was a problem hiding this comment.
Can we add for this field also markdown support in storybook. Maybe not this PR but new ticket.
There was a problem hiding this comment.
we do have markdown support for the Description now :) or which one you mean?
There was a problem hiding this comment.
Ok, cool, but why do you need ?
There was a problem hiding this comment.
@vedrani this is the only one way to add new-line in this react-markdown :( and it's not just , but (with two spaces in the end)... I know.. but it works :) nothing else didn't what I've tried, like multiple enters, <br/>, , \r\n, none of them :(
FX-121
Description
Add css prefix for
clip-pathto add Safari support