Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Node 23 #285

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Support Node 23 #285

merged 2 commits into from
Nov 23, 2024

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 19, 2024

Node.js 23 was published on 2024-10-16 https://nodejs.org/en/blog/release/v23.0.0

@trivikr
Copy link
Contributor Author

trivikr commented Nov 19, 2024

As per https://node.green/, Unicode 16.0 is not supported in Node.js 23.

Should the value in lib and target be es2023 due to this missing feature?

bases/node23.json Outdated Show resolved Hide resolved
@trivikr
Copy link
Contributor Author

trivikr commented Nov 19, 2024

The es2024 target are going to be supported in TypeScript 5.7 expected to release on 2024-11-21

@orta
Copy link
Member

orta commented Nov 20, 2024

I think it's fine to wait for the 5.7 to go live, and then merge this with 24?

@trivikr
Copy link
Contributor Author

trivikr commented Nov 22, 2024

@orta
Copy link
Member

orta commented Nov 23, 2024

👍🏻

@orta orta enabled auto-merge November 23, 2024 14:27
@orta orta disabled auto-merge November 23, 2024 14:27
@orta orta merged commit 0e2ba35 into tsconfig:main Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants