-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement builtin mode for keepassxc #4149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Instead of a new set of template functions, I think this different "mode" for opening KeepassXC databases. Currently chemzoi supports "cache-password" and "open" modes. I think this should be a new "builtin" mode.
What do you think?
Sounds reasonable. |
5396dc8
to
f42961b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is looking excellent, and I will do a full review after the weekend.
Please also check the contributing guide for low-hanging fruit.
But, thank you, this PR is excellent.
5e0b26c
to
a5f1457
Compare
assets/chezmoi.io/docs/reference/templates/keepassxc-functions/index.md
Outdated
Show resolved
Hide resolved
Thank you, this is looking excellent. Once you've made the small changes to the documentation, this should be ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Just a couple of comments and only one "required" change (for the docs).
assets/chezmoi.io/docs/reference/templates/keepassxc-functions/index.md
Outdated
Show resolved
Hide resolved
@bakito Thanks for making the changes. Please can you squash everything into a single commit, and then this should be good to go. |
Signed-off-by: bakito <[email protected]>
Thank you @bakito for your excellent work and patience here! |
Implements: #4148