-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: resolveWorkspace, resolveWorkspacePkgs, resolveWorkspacePkgsGraph #118
base: main
Are you sure you want to change the base?
Conversation
Hi @pi0: I have finished this PR. Please review it, THX |
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 89.40% 91.39% +1.99%
==========================================
Files 5 5
Lines 434 616 +182
Branches 37 83 +46
==========================================
+ Hits 388 563 +175
- Misses 46 53 +7
|
Hi @danielroe, If you have any questions or concerns, please let me know, Thanks |
@aa900031, I create a PR in order to fix lint issue on windows aa900031#1. |
fix: add `exports.types` field (unjs#120)
@Barbapapazes Thank you 🙇 |
# Conflicts: # package.json # pnpm-lock.yaml
@danielroe @pi0 Thank you for review, this feature is crucial for supporting monorepo in changelogen. If possible, please merge it as soon as you can. If there is any question, please let me know. |
@danielroe @pi0 I've submitted this pull request (PR) a while ago and noticed that it hasn't received any attention. I wanted to ask if you think this feature is necessary? If it's not needed, I'm considering implementing it myself instead of relying on unjs. I would appreciate a response. |
@aa900031 definitely this s a nice PR and also required for us! I need to refactor some changes before merging to the main. |
Would be awesome to have monorepo support for changelogen and this PR looks already pretty good. I hope it can be merged relatively soon! |
Resolve issue #117
In this PR, I have implement two functions:
resolveWorkspace
: that detects explicit monorepo workspaces using the detected field in package.json or pnpm-workspace.yaml, returning a workspaces.resolveWorkspacePkgs
: can also be introduced to accept resolved workspace config and read all of its packages.resolveWorkspacePkgsGraph
: sort packages with topological.All of the above support: pnpm, lerna, yarn, npm