ci: enable warnings as errors

unoplatform · Aug 23, 2024 · 5573c0b · 5573c0b
1 parent d713aae
commit 5573c0b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/build/.azure-pipelines.yml b/build/.azure-pipelines.yml
@@ -70,14 +70,14 @@ stages:
         $adjustedPackageVersion="$(GitVersion.SemVer)".ToLower();
 
         # Pack the Uno.Sdk
-        & dotnet build src\Uno.Sdk\Uno.Sdk.csproj -c Release -p:PackageVersion=$adjustedPackageVersion -p:Version=$(GitVersion.AssemblySemVer) /bl:$(build.artifactstagingdirectory)\uno.sdk-pack.binlog -o $(build.artifactstagingdirectory)
+        & dotnet build src\Uno.Sdk\Uno.Sdk.csproj -c Release -p:PackageVersion=$adjustedPackageVersion -p:Version=$(GitVersion.AssemblySemVer) /bl:$(build.artifactstagingdirectory)\uno.sdk-pack.binlog -o $(build.artifactstagingdirectory) /p:TreatWarningsAsErrors=true /p:NoWarn=NU1507;CS1591
       displayName: Pack Uno.Sdk
 
     - powershell: |
         $adjustedPackageVersion="$(GitVersion.SemVer)".ToLower();
 
         # Pack the Uno.Templates
-        & dotnet build src\Uno.Templates\Uno.Templates.csproj -c Release -p:PackageVersion=$adjustedPackageVersion -p:Version=$(GitVersion.AssemblySemVer) /bl:$(build.artifactstagingdirectory)\uno.templates-pack.binlog -o $(build.artifactstagingdirectory)
+        & dotnet build src\Uno.Templates\Uno.Templates.csproj -c Release -p:PackageVersion=$adjustedPackageVersion -p:Version=$(GitVersion.AssemblySemVer) /bl:$(build.artifactstagingdirectory)\uno.templates-pack.binlog -o $(build.artifactstagingdirectory) /p:TreatWarningsAsErrors=true /p:NoWarn=NU1507;CS1591
 
       displayName: Pack Uno.Templates
 

diff --git a/build/templates/package-validation.yml b/build/templates/package-validation.yml
@@ -188,7 +188,7 @@ steps:
       {
         # Build the app
         pushd $testName 
-        & dotnet build $testName.sln "/bl:$(System.ArtifactsDirectory)/$testName.$(Agent.OS).$dotnetVersion.binlog"
+        & dotnet build $testName.sln "/bl:$(System.ArtifactsDirectory)/$testName.$(Agent.OS).$dotnetVersion.binlog" /p:TreatWarningsAsErrors=true /p:NoWarn=NU1507;CS1591
         if ($LASTEXITCODE -ne 0)
         {
           echo "Build failed for $testName"

diff --git a/build/templates/template-validation.yml b/build/templates/template-validation.yml
@@ -63,11 +63,11 @@ steps:
       if ('${{ parameters.templateName }}' -eq 'unoapp-uwp')
       {
           $msbuild = vswhere -latest -requires Microsoft.Component.MSBuild -find MSBuild\**\Bin\MSBuild.exe
-          & $msbuild /r "/bl:$(build.artifactstagingdirectory)\$(Agent.JobName).binlog"
+          & $msbuild /r "/bl:$(build.artifactstagingdirectory)\$(Agent.JobName).binlog" /p:TreatWarningsAsErrors=true /p:NoWarn=NU1507;CS1591
       }
       else
       {
-          & dotnet build "/bl:$(build.artifactstagingdirectory)\$(Agent.JobName).binlog"
+          & dotnet build "/bl:$(build.artifactstagingdirectory)\$(Agent.JobName).binlog" /p:TreatWarningsAsErrors=true /p:NoWarn=NU1507;CS1591
       }
       
       if ($LASTEXITCODE -ne 0)