feat: Add ContentDialog elevation on WASM & Android, partially on iOS
#7022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MartinZikmund
changed the title
ContentDialog elevation on WASM & Android
MartinZikmund
changed the title
ContentDialog elevation on WASM & AndroidContentDialog elevation on WASM & Android, partially on iOS
ajpinedam
approved these changes
Sep 11, 2021
MartinZikmund
force-pushed
the
dev/mazi/contentdialog-elevation
branch
from
2feb4a3 to
e689937
Compare
carldebilly
approved these changes
Sep 16, 2021
MartinZikmund
force-pushed
the
dev/mazi/contentdialog-elevation
branch
from
e689937 to
cbc56bb
Compare
MartinZikmund
added
the
ready-to-merge
MartinZikmund
force-pushed
the
dev/mazi/contentdialog-elevation
branch
2 times, most recently
from
b7fd0f2 to
4b49cc5
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MartinZikmund
force-pushed
the
dev/mazi/contentdialog-elevation
branch
2 times, most recently
from
332c89a to
69f752b
Compare
|
Are we able to validate the presence of the elevation via a screenshot color peeking ? |
MartinZikmund
force-pushed
the
dev/mazi/contentdialog-elevation
branch
from
69f752b to
a11300f
Compare
jeromelaban
approved these changes
Mar 22, 2022
|
Looks like SetElevation is missing somewhere. |
MartinZikmund
force-pushed
the
dev/mazi/contentdialog-elevation
branch
from
1b2e8df to
22399e9
Compare
MartinZikmund
force-pushed
the
dev/mazi/contentdialog-elevation
branch
from
e51583c to
8f8bec4
Compare
MartinZikmund
removed
the
ready-to-merge
agneszitte
approved these changes
Aug 8, 2022
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@MartinZikmund there is some conflicts that needs to be resolved ;) |
MartinZikmund
force-pushed
the
dev/mazi/contentdialog-elevation
branch
from
8f8bec4 to
c06c602
Compare
github-actions
bot
added
area/skia ✏️
carldebilly
approved these changes
Jan 12, 2023
|
Closing to wait for the port from #19127, will be revisited after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): part of #7021
PR Type
What kind of change does this PR introduce?
What is the current behavior?
No shadow.
What is the new behavior?
Shadow working on WASM and Android. On iOS only without corner radius (not sure why - maybe @carldebilly would know?).
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):