Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutoForm : Fix disabled from field config #943

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from

Conversation

damienroche
Copy link
Contributor

@damienroche damienroche commented Dec 5, 2024

πŸ”— Linked issue

#942

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

When using the field-config prop, and set disabled to true inside inputProps object, the ` should display a disabled input. This PR close #942

AutoFormFieldInput.vue

+:disabled="config?.inputProps?.disabled ?? disabled"
-:disabled="disabled"

This behavior should be fixed for other types of fields (e.g., Number, Boolean, etc.).

πŸ“Έ Screenshots (if appropriate)

Capture d’écran 2024-12-05 aΜ€ 12 02 50

πŸ“ Checklist

  • I have linked an issue or discussion.

Components updated

  • AutoFormFieldInput
  • AutoFormFieldNumber
  • AutoFormFieldBoolean
  • AutoFormFieldEnum
  • AutoFormFieldDate
  • AutoFormFieldFile

@zernonia
Copy link
Member

Can we please update apps/www/src/lib/registry/default/ui/auto-form/AutoFormFieldInput.vue as well? 😁

@damienroche
Copy link
Contributor Author

@zernonia done

@damienroche
Copy link
Contributor Author

@zernonia i've also updated disabled for other type
here's the demo :
https://stackblitz.com/edit/aaxbuu-hskljw88?file=src%2FApp.vue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AutoForm, fix disabled from field-config
3 participants