USWDS-Site - Test: In-page nav scroll to nested headers #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejiaj
commented
Nov 20, 2024
| @@ -15,7 +15,7 @@ | |||
| <div class="usa-in-page-nav-container"> | |||
| <aside class="usa-in-page-nav" | |||
| aria-label="On this page" | |||
| data-scroll-offset="-120" | |||
There was a problem hiding this comment.
Tip
Chore: To avoid regressions on site we'll need to make this change when feature gets merged. We can cherry pick 256c565.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing uswds/uswds#5878.
Preview link
Utilities margin and padding →
Original error was reproducible on this page. The margin and padding links weren't scrolling to correct section.
Testing and review
Ensure bug is fixed
Confirm there aren't regressions
Visit other pages like Design tokens or Component pages and click around the in-page nav to make sure there aren't regressions.