Improve scalability in task_group #1310
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pavelkumbrasev <[email protected]>
Signed-off-by: pavelkumbrasev <[email protected]>
Signed-off-by: pavelkumbrasev <[email protected]>
Signed-off-by: pavelkumbrasev <[email protected]>
pavelkumbrasev
requested review from
aleksei-fedotov,
vossmjp,
dnmokhov,
kboyarinov,
sarathnandu and
isaevil
Signed-off-by: pavelkumbrasev <[email protected]>
isaevil
reviewed
Feb 9, 2024
kboyarinov
reviewed
Feb 9, 2024
Signed-off-by: pavelkumbrasev <[email protected]>
Co-authored-by: Konstantin Boyarinov <[email protected]>
kboyarinov
reviewed
Feb 13, 2024
Signed-off-by: pavelkumbrasev <[email protected]>
Co-authored-by: Ilya Isaev <[email protected]>
Signed-off-by: pavelkumbrasev <[email protected]>
pavelkumbrasev
force-pushed
the
dev/pavelkumbrasev/fix_tg_scalability
branch
from
d8b5874 to
22918c4
Compare
include/oneapi/tbb/task_group.h
Outdated
| template<typename F> | ||
| class function_task : public task { | ||
| const F m_func; | ||
| class task_group_continuation { |
There was a problem hiding this comment.
Why is it called continuation, while it is clearly does the reference management only?
Continuation has always been a task that executes after its child tasks have been completed.
There was a problem hiding this comment.
This code will be executed after all the children tasks so technically it is still a continuation :)
There was a problem hiding this comment.
If I get it right, you suggesting to call the first task a "task" and all the tasks that will execute after it a "continuation". Right? Sounds bad to me...
I agree that it can be a name for a local variable, but I don't think it can be a name for the whole class.
There was a problem hiding this comment.
Please consider to rename into distributed_reference_counter
Signed-off-by: pavelkumbrasev <[email protected]>
Signed-off-by: pavelkumbrasev <[email protected]>
Signed-off-by: pavelkumbrasev <[email protected]>
pavelkumbrasev
force-pushed
the
dev/pavelkumbrasev/fix_tg_scalability
branch
3 times, most recently
from
0beca21 to
f00a27c
Compare
Signed-off-by: pavelkumbrasev <[email protected]>
pavelkumbrasev
force-pushed
the
dev/pavelkumbrasev/fix_tg_scalability
branch
from
f00a27c to
0e7b969
Compare
Signed-off-by: pavelkumbrasev <[email protected]>
Signed-off-by: pavelkumbrasev <[email protected]>
Signed-off-by: pavelkumbrasev <[email protected]>
isaevil
reviewed
Feb 22, 2024
Co-authored-by: Ilya Isaev <[email protected]>
Signed-off-by: pavelkumbrasev <[email protected]>
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
task_group has a flat reference counting scheme i.e., there is a central reference counter where all the created tasks should increase/decrease reference during execution.
This approach works fine while tasks are big and submitted from small number of threads (<8).
When multiple threads will start tree-like algorithm with a lot of tasks the overall performance of the application will drastically degrade with increasing number of threads due to huge synchronization cost.
This patch introduce tree-like scheme in task_group i.e., if nesting is detected continuation will be created and nested tasks will work with reference counter of this newly created continuation instead task_group reference counter.
This process of continuation creation will repeat itself each time nesting is detected.
Fixes #313
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
@vossmjp
Other information