-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove a key definition of ImportMetaEnv #19077
Open
yunics-highfield
wants to merge
7
commits into
vitejs:main
Choose a base branch
from
yunics-highfield:feature/strict-import-meta-env
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: remove a key definition of ImportMetaEnv #19077
yunics-highfield
wants to merge
7
commits into
vitejs:main
from
yunics-highfield:feature/strict-import-meta-env
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunics-highfield
changed the title
Remove a key definition of ImportMetaEnv
feat!: Remove a key definition of ImportMetaEnv
Dec 26, 2024
yunics-highfield
changed the title
feat!: Remove a key definition of ImportMetaEnv
feat!: ImportMetaEnv Type Improvement
Dec 26, 2024
yunics-highfield
changed the title
feat!: ImportMetaEnv Type Improvement
feat: ImportMetaEnv Type Improvement
Dec 26, 2024
yunics-highfield
changed the title
feat: ImportMetaEnv Type Improvement
feat!: Remove a key definition of ImportMetaEnv
Dec 26, 2024
yunics-highfield
changed the title
feat!: Remove a key definition of ImportMetaEnv
feat!: remove a key definition of ImportMetaEnv
Dec 26, 2024
sapphi-red
reviewed
Dec 26, 2024
Co-authored-by: 翠 / green <[email protected]>
yunics-highfield
changed the title
feat!: remove a key definition of ImportMetaEnv
feat: remove a key definition of ImportMetaEnv
Dec 26, 2024
I'll handle the lint error later. |
sapphi-red
reviewed
Dec 26, 2024
Co-authored-by: 翠 / green <[email protected]>
sapphi-red
added
the
p2-to-be-discussed
Enhancement under consideration (priority)
label
Dec 27, 2024
Would you add a document about this here? |
What do you think of this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even if you want to make the type of
ImportMetaEnv
strict, you can't because[key: string]: any
is specified. However, users should be able to choose whether to make the type strict or not.