feat(reporter): add wasm to the compressible assets regex
#19085
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wasm files are often highly compressible and it would be nice to show their compressed size in Vite builds. I found an earlier PR (vitejs#12485) that made this change for some other asset types, and a [comment](vitejs#12485 (comment)) that sounded open to the addition of wasm to the list, which I've added.
yurivish
changed the title
wasm to the compressible assets regexwasm to the compressible assets regex
sapphi-red
changed the title
wasm to the compressible assets regexwasm to the compressible assets regex
sapphi-red
changed the title
wasm to the compressible assets regexwasm to the compressible assets regex
sapphi-red
added
the
p2-nice-to-have
sapphi-red
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasm files are often highly compressible. It would be nice to show their compressed size in Vite builds. This PR is a one-line change that should show their compressed size after the build is complete.
I found an earlier PR (#12485) that made this change for some other asset types, and it had a comment that sounded open to the addition of wasm to the list:
Description
Allows
.wasmfiles to show their compressed size in the Vite build results