Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vscode): use unjs/unbuild for bundling #4998

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

KermanX
Copy link
Collaborator

@KermanX KermanX commented Nov 8, 2024

Use https://github.com/unjs/unbuild to bundle the VSCode extension, also as a preparation for #4994.

Notes:

  • To dev the extension: run pnpm dev:vue, the command will exit after the stub files generated (no need to watch file changes), then F5. (Should the tasks defined in .vscode/tasks.json and .vscode/launch.json be restored?)
  • To build the extension: like before.
  • Other packages except the VSCode extension remain unchanged.

Copy link

pkg-pr-new bot commented Nov 8, 2024

Open in Stackblitz

vue-component-meta

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-meta@4998

vue-component-type-helpers

npm i https://pkg.pr.new/vuejs/language-tools/vue-component-type-helpers@4998

@vue/language-plugin-pug

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-plugin-pug@4998

@vue/language-server

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-server@4998

@vue/language-service

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-service@4998

@vue/language-core

npm i https://pkg.pr.new/vuejs/language-tools/@vue/language-core@4998

vue-tsc

npm i https://pkg.pr.new/vuejs/language-tools/vue-tsc@4998

@vue/typescript-plugin

npm i https://pkg.pr.new/vuejs/language-tools/@vue/typescript-plugin@4998

commit: 6eceeb6

@KermanX KermanX changed the title chore: use unjs/unbuild chore(vscode): use unjs/unbuild for bundling Nov 8, 2024
@sxzz
Copy link
Member

sxzz commented Nov 27, 2024

Hey, what do you think about switching to tsdown, powered by Rolldown, for faster speed?

@johnsoncodehk johnsoncodehk force-pushed the master branch 2 times, most recently from ae194a1 to 940b97c Compare December 18, 2024 12:15
@@ -573,7 +574,9 @@
"esbuild": "latest",
"esbuild-visualizer": "latest",
"reactive-vscode": "^0.2.9",
"rollup-plugin-visualizer": "^5.12.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that you've replaced sonda with rollup-plugin-visualizer. I will not try to convince you to use sonda, but if this was a technical decision, could you share the reason? I would appreciate your feedback so I can improve it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @filipsobol, first of all thank you for developing sonda. One of the reasons is that we want the PR to keep the most relevant changes so that it has a greater chance of being merged. Another reason is that the output file treemap is paginated in Sonda, and we cannot visually check whether the modules that need to be shared by multiple files have been correctly split.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this gives me some interesting ideas 🤔

Another reason is that the output file treemap is paginated in Sonda, and we cannot visually check whether the modules that need to be shared by multiple files have been correctly split.

By visual check, do you mean manual or automated visual check? You should be able to switch between chunks using the dropdown menu in the upper-left corner, but I can imagine that it may require extra work or even problems in automated tests (e.g. if it visually compares two reports).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants