types(useRoute): add generic for params #1159
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version
4.0.12
Steps to reproduce
Pass params to function with typed arguments
Error message
Argument of type 'string | string[]' is not assignable to parameter of type 'string'.
Type 'string[]' is not assignable to type 'string'.
What is expected?
Possability to pass generic for params types, like in react-router-dom hook useParams
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/09ce5bbfc2d507d35f6e8185a1f6a617bfca20fc/types/reach__router/index.d.ts#L182
How will it look like
type Params = {
id: string
type: ResourceType
}
const route = useRoute<Params>()