Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Matcher with param parsing #2415

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open

New Matcher with param parsing #2415

wants to merge 26 commits into from

Conversation

posva
Copy link
Member

@posva posva commented Dec 5, 2024

No description provided.

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for vue-router canceled.

Name Link
🔨 Latest commit 2d138b9
🔍 Latest deploy log https://app.netlify.com/sites/vue-router/deploys/676a82d467bffc0008853818

Copy link

pkg-pr-new bot commented Dec 5, 2024

Open in Stackblitz

npm i https://pkg.pr.new/vue-router@2415

commit: 65a0940

Copy link

codecov bot commented Dec 6, 2024

Codecov Report

Attention: Patch coverage is 66.78832% with 91 lines in your changes missing coverage. Please review.

Project coverage is 92.48%. Comparing base (c73e83f) to head (d462758).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/router/src/new-route-resolver/matcher.ts 67.76% 49 Missing ⚠️
...uter/src/new-route-resolver/matchers/path-param.ts 2.85% 34 Missing ⚠️
...s/router/src/new-route-resolver/matchers/errors.ts 54.54% 5 Missing ⚠️
...s/router/src/new-route-resolver/matcher-pattern.ts 95.34% 2 Missing ⚠️
packages/router/src/new-route-resolver/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2415      +/-   ##
==========================================
- Coverage   94.88%   92.48%   -2.41%     
==========================================
  Files          34       41       +7     
  Lines        2993     3247     +254     
  Branches      845      889      +44     
==========================================
+ Hits         2840     3003     +163     
- Misses        150      240      +90     
- Partials        3        4       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant