fix: disallow epub:prefix on embedded SVG
#1583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduce a new improved structure to the feature file, based on a list of Rules each having one or several Examples. Each Rule matches a normative statement in the specification. Examples are previous Scenarios (both keywords are synonyms), but now better grouped under each normative statement it relates to. - Also move a couple prefix-related test cases to the general vocabularies feature, for keeping closer to the specification. - Add a few tests cases for some untested statements.
EPUB 3 Vocabularies section currently contains the following statemnt: > For future compatibility with alternative serializations of the package > document, EPUB creators MUST NOT declare a prefix for the Dublin Core > `/elements/1.1/` namespace. This commit implements a check for that statement in the prefix parsing code, reported as a new error message OPF-007c.
The spec only requires SVG to be well-formed, but one can argue that attributes in the EPUB namespace can only be defined by the EPUB specs and therefore should still be validated. For instance, EPUB already specifies where `epub:type` is allowed in SVG, as a normative statement. This commit updates the persmissive SVG schema to reject all attributes in the `http://www.idpf.org/2007/ops` namespace except the known ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also disallow unknown
epub:*attributes in SVG