Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies between the definitions of the set functions #99

Closed
hartig opened this issue Jun 15, 2023 · 3 comments
Closed

Inconsistencies between the definitions of the set functions #99

hartig opened this issue Jun 15, 2023 · 3 comments

Comments

@hartig
Copy link
Contributor

hartig commented Jun 15, 2023

When working on PR #98 I noticed several inconsistencies between the definitions of the set functions.

  1. Some definitions use "card[S]" to denote the cardinality of a sequence S (e.g., Sec.18.5.1.3 Sum) whereas others use "|S|" (e.g., Sec.18.5.1.7 GroupConcat). My proposal is to consistently use the latter.
  2. Some definitions use the word "when" when capturing conditions (e.g., Sec.18.5.1.3 Sum) whereas others use "where" (e.g., Sec.18.5.1.4 Avg). My proposal is to consistently use the word "if".
  3. Additionally, the definition of GroupConcat contains only the function signature without the scalarvals argument. A second function signature needs to be added that contains the scalarvals argument.
@hartig
Copy link
Contributor Author

hartig commented Jun 15, 2023

To avoid merge conflicts with the changes in PR #98 I will wait with addressing the points in this issue until we are done with PR #98.

@hartig
Copy link
Contributor Author

hartig commented Jun 16, 2023

Another inconsistency that I forgot to mention:
4. In some definitions, the indexes of elements in the given sequence start from 1 (e.g., Sec.18.5.1.3 Sum) whereas other definitions use indexes starting from 0 (e.g., Sec.18.5.1.7 GroupConcat). My proposal is to consistently use the former (i.e., starting from 1).

@hartig
Copy link
Contributor Author

hartig commented Jul 6, 2023

Closed by PR #108

@hartig hartig closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant