-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn the input to Group(..) and to Aggregation(..) into solution sequences #98
Conversation
… into solution sequences rather then sets/multisets of solutions; see #95 (comment)
Currently, this change uses Option 1 of #95 (comment) to convert the input to the Group operator from a multiset of solution mappings into a sequence of solution mappings. Following this change, this PR changes the definitions of both the Group operator and the Aggregation operator. In particular, the definition of the Group operator now captures explicitly that the operator produces partial functions from keys to solution sequences. Similarly, the definition of the Aggregation operator now captures that:
Additionally, I have adapted the example below the definition of the Aggregation operator according to these changes. However, that's only a part of the changes that are needed to implement @kasei 's proposal. The next step is to adapt the definitions of the set functions. For instance, in Section 18.5.1.1 Set Functions, the symbol M must now denote a lists of lists rather than a multiset of lists, and the same holds for M in Section 18.5.1.2 Count and also in the next sections. As another consequence, the definition of the Flatten function (as used in Section 18.5.1.2 Count) needs to be changed as well. @kasei any comments so far? |
Other than the comment about needing to define |
…f tuples, as is used in the definition of F(Ψ) for the Aggregation operator; see #98 (comment)
…ed over sequences of lists now, rather than multisets of lists
I now have changed the definitions of the set functions such that they are defined over sequences of lists, rather than over multisets of lists. With this change, the PR is ready to be reviewed. |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
(tangent... could be moved to a new issue) I'm probably in the minority, and it certainly would require a chunk of work by editors and other contributors, but I find myself wishing that a lot more content were |
|
…sted in ff80086#commitcomment-118517879 ; additionally addresses the following comments: ff80086#r118402147 ff80086#r118507227 ff80086#r118508717
I have pushed a new commit to this PR (see d808fb8). This commit addresses Andy's concerns about my changes to the definition of Distinct by implementing his suggestion to separate the definitions; that is, with this new commit, the definition of Distinct is now back to how it always was and there is a new function called Dedup that is used in the definition of the Aggregation operator. Additionally, this commit addresses the following comments:
Addressed by changing "Every element" to "Every unique element" as suggested by @TallTed .
I kept the ≠ in the condition for the indexes i and j but integrated "is not the same term as" into the text of the corresponding bullet point.
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I allowed myself some questions I had while reviewing this MR but they are not directly related with it.
Yes, I am hoping to review it. Sorry for the delay. Reviewing changes in RDF docs has also taken up time. |
No worries. Take your time! I just wanted to quickly check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay, I lost track of this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me. Solution sequences are easier to think about.
... as suggested by @kasei in #95 (comment)
Preview | Diff