Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish minutes of 2024-11-07 meeting #720

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Publish minutes of 2024-11-07 meeting #720

merged 1 commit into from
Nov 13, 2024

Conversation

Rob--W
Copy link
Member

@Rob--W Rob--W commented Nov 7, 2024

Generated from https://docs.google.com/document/d/1QkwhEMtMS67JBUkl_WVPZ4lRSKoWcQNlLJSf_GwSXg8/edit using the tool and process from #105.

During this meeting we discussed or mentioned issues #718, #531, #708, #711, #713, #715, #716, #717, #719, #527, #532, #501 and PR #546.

In this PR I also included the brief meeting notes of the previous canceled meeting (#709), because I never created a PR for it.

_minutes/2024-11-07-wecg.md Outdated Show resolved Hide resolved
_minutes/2024-11-07-wecg.md Outdated Show resolved Hide resolved
_minutes/2024-11-07-wecg.md Outdated Show resolved Hide resolved
_minutes/2024-11-07-wecg.md Outdated Show resolved Hide resolved
_minutes/2024-11-07-wecg.md Outdated Show resolved Hide resolved
_minutes/2024-11-07-wecg.md Outdated Show resolved Hide resolved
_minutes/2024-11-07-wecg.md Outdated Show resolved Hide resolved

[Issue 717](https://github.com/w3c/webextensions/issues/717): Request: [ContextMenus] Include `<canvas>`s in the "page" ContextType (or it's own ContextType)

* [simeon] The only way to match &lt;canvas> elements is to specify “all”. The request is to offer a specific contextType to match &lt;canvas>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [simeon] The only way to match &lt;canvas> elements is to specify “all”. The request is to offer a specific contextType to match &lt;canvas>.
* [simeon] The only way to match `<canvas>` elements is to specify “all”. The request is to offer a specific `contextType` to match `<canvas>`.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

&lt; is a valid way to render < in markdown, at least on Github.

I have applied this suggestion since the title is also using backticks around the canvas; but in the future let's not wrap <canvas> unnecessarily. I try to minimize the amount of unnecessary formatting in the notes because it may be distracting from its content.

* [simeon] Sounds like we're aligned?
* [rob] I'd like to see more details on use cases. One of the comments was to support a CSS selector to match context menus by selector. That would be a more general way to support this capability. I'm generally in favor of CSS selector. I'm opposed to adding “canvas” ContextType when there is no special context associated with it.
* [timothy] We'd still have the issue of needing getTargetElement to meaningfully interact with the element
* [simeon] Agreed, I think we're discussing which solution to issue 717 is the right approach.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* [simeon] Agreed, I think we're discussing which solution to issue 717 is the right approach.
* [simeon] Agreed, I think we're discussing which solution to issue #717 is the right approach.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually linkify "issue" numbers (e.g. would be [issue 717](https://github.com/w3c/webextensions/issue/717)), but in this case the issue being discussed is the same as the header, so I did not link it.

Is 717 the issue you had in mind, or was it 716?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I meant 716. Please link-ify 😄

_minutes/2024-11-07-wecg.md Outdated Show resolved Hide resolved
@dotproto
Copy link
Member

dotproto commented Nov 7, 2024

I have not applied these changes to the Google Doc.

_minutes/2024-10-24-wecg.md Outdated Show resolved Hide resolved
@Rob--W Rob--W force-pushed the meeting-2024-11-07 branch from e8efb80 to 703182f Compare November 13, 2024 12:35
@Rob--W
Copy link
Member Author

Rob--W commented Nov 13, 2024

I have applied the requested changes and updated the doc too. Thanks for the review!

* [simeon] Sounds like we're aligned?
* [rob] I'd like to see more details on use cases. One of the comments was to support a CSS selector to match context menus by selector. That would be a more general way to support this capability. I'm generally in favor of CSS selector. I'm opposed to adding “canvas” ContextType when there is no special context associated with it.
* [timothy] We'd still have the issue of needing getTargetElement to meaningfully interact with the element
* [simeon] Agreed, I think we're discussing which solution to issue 717 is the right approach.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I meant 716. Please link-ify 😄

@Rob--W Rob--W force-pushed the meeting-2024-11-07 branch from 703182f to 3740adb Compare November 13, 2024 15:59
@Rob--W Rob--W merged commit d168073 into main Nov 13, 2024
1 check passed
@Rob--W Rob--W deleted the meeting-2024-11-07 branch November 13, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants