Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: address flake8 findings in webdriver/ #43096

Merged
merged 2 commits into from
Nov 17, 2023
Merged

infra: address flake8 findings in webdriver/ #43096

merged 2 commits into from
Nov 17, 2023

Conversation

thiagowfx
Copy link
Member

@thiagowfx thiagowfx requested a review from whimboo November 11, 2023 23:45
@thiagowfx
Copy link
Member Author

Unit tests are (correctly!) failing. We'll need to fix the lint issues alongside this PR in order for them to pass.

@thiagowfx thiagowfx force-pushed the thiagowfx/flake8 branch 7 times, most recently from 677f9d9 to ac91346 Compare November 12, 2023 22:56
@thiagowfx
Copy link
Member Author

Now there's only one error remaining.

webdriver/tests/bidi/input/perform_actions/invalid.py:495:1: F811 redefinition of unused 'test_params_pointer_action_up_down_button_missing' from line 416

@jrandolf please help here: which function should be renamed, and to what?

@thiagowfx thiagowfx enabled auto-merge (squash) November 12, 2023 22:57
@thiagowfx thiagowfx force-pushed the thiagowfx/flake8 branch 2 times, most recently from 7590d0f to 08bd158 Compare November 12, 2023 23:07
@thiagowfx thiagowfx requested a review from whimboo November 14, 2023 22:31
@thiagowfx
Copy link
Member Author

If there are no further comments, I believe this is ready to go.

@whimboo whimboo closed this Nov 15, 2023
auto-merge was automatically disabled November 15, 2023 15:27

Pull request was closed

@whimboo whimboo reopened this Nov 15, 2023
@thiagowfx
Copy link
Member Author

@whimboo @jgraham could you please re-review? I'd ask an admin to merge this already, but the "changes requested" status blocks it

@whimboo whimboo dismissed jgraham’s stale review November 16, 2023 14:20

Requested change is done. I don't see any other blockers.

@whimboo
Copy link
Contributor

whimboo commented Nov 16, 2023

@web-platform-tests/admins can you please admin merge? The seen failures are not related to this particular change. Thanks.

gsnedders
gsnedders requested changes Nov 16, 2023
View reviewed changes
tools/tox.ini Outdated Show resolved Hide resolved
@thiagowfx thiagowfx force-pushed the thiagowfx/flake8 branch 2 times, most recently from 5628ea0 to 5644751 Compare November 17, 2023 13:27
@thiagowfx thiagowfx changed the title infra: run flake8 in webdriver/ infra: address flake8 findings in webdriver/ Nov 17, 2023
infra: address flake8 findings in webdriver/
fbb37a9 
Rename duplicate test to test_params_pointer_action_move_coordinate_missing

Bug: web-platform-tests/rfcs#171
Cmdline: flake8 --append-config=tools/flake8.ini webdriver/tests/bidi                                                                                                                                                 :
@thiagowfx thiagowfx enabled auto-merge (squash) November 17, 2023 13:30
@thiagowfx thiagowfx mentioned this pull request Nov 17, 2023
Open
3 tasks
@thiagowfx
Copy link
Member Author

@DanielRyanSmith and/or @jgraham could you admin merge? This is addressing the linter issues, without enforcing the linter. The enforcement discussion is still WIP at web-platform-tests/rfcs#171

@thiagowfx thiagowfx requested a review from gsnedders November 17, 2023 13:33
@gsnedders gsnedders disabled auto-merge November 17, 2023 15:47
@gsnedders gsnedders merged commit 605a199 into master Nov 17, 2023
16 of 21 checks passed
@gsnedders gsnedders deleted the thiagowfx/flake8 branch November 17, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrandolf-2 jrandolf-2 jrandolf-2 approved these changes

@Lightning00Blade Lightning00Blade Lightning00Blade approved these changes

@gsnedders gsnedders gsnedders approved these changes

@whimboo whimboo whimboo approved these changes

@DanielRyanSmith DanielRyanSmith Awaiting requested review from DanielRyanSmith

@foolip foolip Awaiting requested review from foolip

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@juliandescottes juliandescottes Awaiting requested review from juliandescottes

@sadym-chromium sadym-chromium Awaiting requested review from sadym-chromium

@shs96c shs96c Awaiting requested review from shs96c

@jgraham jgraham Awaiting requested review from jgraham

Assignees

@foolip foolip

@DanielRyanSmith DanielRyanSmith

Labels
flake8.ini infra tox.ini webdriver webdriver-bidi wg-testing_browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@thiagowfx @whimboo @jgraham @gsnedders @Lightning00Blade @jrandolf-2 @foolip @wpt-pr-bot @moz-wptsync-bot @DanielRyanSmith