Start running the parsed file lints against support files #48320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
added
appmanifest
client-hints
compute-pressure
content-security-policy
cookies
fenced-frame
fetch
focus
html
infra
intersection-observer
lint
loading
nav-tracking-mitigations
performance-timeline
presentation-api
resource-timing
service-workers
shared-storage
shared-storage-selecturl-limit
speculation-rules
wg-cg_privacycg
wg-cg_wicg
wg-das
wg-s_htmlwg
wg-s_webapps
wg-s_webperf
wg-secondscreen
wg-sw
workers
labels
wpt-pr-bot
requested review from
caitp,
christianliebel,
DanielRyanSmith,
domenic,
foolip,
hillbrad,
igrigorik,
jdm,
jgraham,
kenchris and
marcoscaceres
gsnedders
force-pushed
the
lint-support-files
branch
from
513ee71 to
f6f4163
Compare
wpt-pr-bot
requested review from
mgiuca,
mikewest,
mkruisselbrink,
mnot,
plehegar,
szager-chromium,
tarunban,
tidoust,
wanderview,
yoavweiss,
youennf and
yutakahirano
This is largely motivated by ensuring that people aren't including testharnessreport.js in support files which are then included via fetch_tests_from_window, and most of the files changed here are removing redundant inclusions here. We also find a few other errors, such as testdriver-vendor.js being omitted and invalid values for <meta name=timeout>, which are also fixed. Finally, add a few things to the allowlist.
gsnedders
force-pushed
the
lint-support-files
branch
from
f6f4163 to
43a9819
Compare
Ms2ger
reviewed
Oct 10, 2024
|
Is there any way to progress this? |
Ms2ger
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is largely motivated by ensuring that people aren't including
testharnessreport.jsin support files which are then included viafetch_tests_from_window(per docs), and most of the files changed here are removing redundant inclusions here.We also find a few other errors, such as testdriver-vendor.js being omitted and invalid values for
<meta name=timeout>, which are also fixed.Finally, add a few things to the allowlist.
See also WebKit/WebKit#33969, cc @kkinnunen-apple.
For reference:
I believe the only way an HTML
testharness.jssupport file can be included is viafetch_tests_from_window, which means we should just enforce its semantics.The ultimate goal here is to be able to run tests within cross-origin iframes to test site isolation, and we need to be able to make sure we get the right output. web-platform-tests/rfcs#168 would really also solve this, but this still hasn't been done.