Add web platform tests for WebExtensions API in WebDriver Classic #49786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds web platform tests for the new WebExtensions API to be introduced in WebDriver classic. These tests cover both loading and unloading web extensions, including success and error cases. WebKit Bugzilla Bug: https://bugs.webkit.org/show_bug.cgi?id=284922
wpt-pr-bot
requested review from
AutomatedTester,
jgraham,
juliandescottes,
sadym-chromium,
shs96c and
whimboo
kiaraarose
added a commit
to kiaraarose/webdriver
that referenced
this pull request
Dec 19, 2024
…sic. This is a pre-requisite to adding support for cross browser testing for web extensions. PR to test these new commands in WPT: web-platform-tests/wpt#49786
xeenon
reviewed
Dec 19, 2024
| @@ -0,0 +1 @@ | |||
| console.log("Hello, world!"); | |||
There was a problem hiding this comment.
This is minor, but it might be better to use the browser.test.log method — as we plan to use the rest of the test namespace in these test extensions.
Suggested change
| console.log("Hello, world!"); | |
| browser.test.log("Hello, world!"); |
kiaraarose
added a commit
to kiaraarose/webdriver
that referenced
this pull request
Dec 19, 2024
…sic. This is a pre-requisite to adding support for cross browser testing for web extensions. PR to test these new commands in WPT: web-platform-tests/wpt#49786
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds web platform tests for the new WebExtensions API to be introduced in WebDriver classic.
These tests cover both loading and unloading web extensions, including success and error cases.
WebKit Bugzilla Bug: https://bugs.webkit.org/show_bug.cgi?id=284922