preventing errors when scoped custom element registry is imported on the server #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathandewitt-dev
requested review from
aomarks and
bicknellr
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
I have signed the CLA, not sure why it's failing... maybe it's an issue with my git config.
EDIT: got it. It was indeed an issue with my git config. A little rewriting history with a new email fixed it. |
jonathandewitt-dev
force-pushed
the
master
branch
from
7185b86 to
4f1296d
Compare
sorvell
requested changes
Dec 20, 2024
packages/scoped-custom-element-registry/src/scoped-custom-element-registry.ts
Outdated
Show resolved
Hide resolved
|
I'll add changelog updates when I get home too. |
jonathandewitt-dev
force-pushed
the
master
branch
from
08d89f9 to
77f12d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #601
This will log a warning when imported on the server, and it will effectively do nothing. Otherwise, it will carry on as the polyfill usually would for browser environments.
NOTE: make sure to enable "hide whitespace."