Extract HttpClient to share related API behavior
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/create-client.ts src/utils/authenticate-with-code.ts
|
@cmatheson Thanks for approving, though I think it could use one more look over since there were some merge conflicts I needed to resolve after merging in |
mthadley
dismissed
cmatheson’s stale review
Just need one more look-over in case I messed something up after solving merge conflicts with main.
dandorman
approved these changes
Dec 30, 2024
cmatheson
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a small collection of
util/functions that interacted with the API and therefore all needed things likeclientIdand/orbaseUrlto be passed in.This extracts a new
HttpClientclass that encompasses those behaviors. This class is not part of the public API and is an internal implementation detail only.