Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 3.13-compatible release #34

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Prepare 3.13-compatible release #34

merged 2 commits into from
Oct 30, 2024

Conversation

youknowone
Copy link
Owner

Would it be ok? @lucas42 @cdce8p

distutils is not included because its test does not pass on 3.13

Copy link
Contributor

@lucas42 lucas42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Do you do the actual release process manually? I've not noticed any code in the repo for releasing.

@youknowone
Copy link
Owner Author

youknowone commented Oct 30, 2024

I built packages with update.py and manaully uploaded it using twine previously.
I am going to write a github workflow file for release this time.

@youknowone
Copy link
Owner Author

Let's target the release tomorrow.

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
Comment on lines 22 to 27
- name: Get folders with tests
id: get-folders
run: |
FOLDERS=$(find . -maxdepth 2 -type d -name 'tests' ! -path '*/distutils/*' \
| cut -d "/" -f2 | sort -u \
| jq -Rsc 'split("\n") | map( select(length > 0) )')
Copy link
Contributor

@cdce8p cdce8p Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Get folders with tests
id: get-folders
run: |
FOLDERS=$(find . -maxdepth 2 -type d -name 'tests' ! -path '*/distutils/*' \
| cut -d "/" -f2 | sort -u \
| jq -Rsc 'split("\n") | map( select(length > 0) )')
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: "3.13"
check-latest: true
- name: Get folders with tests
id: get-folders
run: |
pip install -U pip -r requirements_test.txt
FOLDERS=$(python scripts/helper.py list-test-folders --exclude distutils)

Copy link
Contributor

@cdce8p cdce8p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I did a quite more extensive test on my fork and the release was created successfully with all artifacts uploaded.

If you have configured Trusted Publisher in PyPI, I'd say go for it!

push:
tags:
- '*'
pull_request: # FIXME: temporary until release.yaml works
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pull_request: # FIXME: temporary until release.yaml works

Copy link
Owner Author

@youknowone youknowone Oct 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to configure many packages in this repository for trusted publisher. I am trying to set token

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And thank you so much. This is my first time to setup PyPI release by workflow. It must had taken a lot more time without your help.

Co-authored-by: Marc Mueller <[email protected]>
@youknowone youknowone merged commit eb25886 into main Oct 30, 2024
63 checks passed
@youknowone youknowone deleted the 3.13 branch October 30, 2024 16:04
@youknowone
Copy link
Owner Author

@cdce8p
Copy link
Contributor

cdce8p commented Oct 30, 2024

The release action: https://github.com/youknowone/python-deadlib/actions/runs/11597133339

Saw it just know. Unfortunately there is a small issue with standard-chunk. It wasn't uploaded to PyPI. Think I know why as well. Will open a PR shortly.

@youknowone
Copy link
Owner Author

I am not sure but I messed up something. it was actually released in https://github.com/youknowone/python-deadlib/actions/runs/11596984318/job/32289460524

And yeah, chunk doesn't have tests 😂

@cdce8p
Copy link
Contributor

cdce8p commented Oct 30, 2024

And yeah, chunk doesn't have tests 😂

Would have been too easy if it worked the first time 😄 Opened #38.

@youknowone
Copy link
Owner Author

@cdce8p @lucas42 Thank you so much, it would take a lot more time without your helps.

Please tell me if anyone of here be interested in this project ownership. Due to the project's motivation, I am a bit concerned about being the sole owner.

I’d love to share the responsibilities or even donate it to the Python or PyPA organizations one day, but based on PEP 594, that doesn’t seem likely to happen soon, if ever.

@lucas42
Copy link
Contributor

lucas42 commented Oct 30, 2024

@youknowone Yay, that's an amazing milestone! 🎉

It's been great working with you on this up until now. But I don't think I've much to contribute after this point. I'm not an expert in what any of these libraries are doing internally.
In fact, my main motivation this whole time was to be able to do this pull request on another library, which I'm using in a personal project: beetbox/audioread#145

I wish you all the best in future endeavours! 🙇

@cdce8p
Copy link
Contributor

cdce8p commented Oct 30, 2024

I'm in the same category as @lucas42 here, unfortunately. While I'm able to help out from time to time, my main intention was to get "a" working backport lib going so I can update another project for Python 3.13.

@youknowone
Copy link
Owner Author

Thank you for the replies. Yes, I will try to keep them up for a while, though I am not a kind of Python code writer anymore 😂
It was all the good experience with you. I also hope I don't need to publish a new version of them for a while. Probably the next release will be related to a new PEP deprecating more libraries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants