-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare 3.13-compatible release #34
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Do you do the actual release process manually? I've not noticed any code in the repo for releasing.
I built packages with update.py and manaully uploaded it using twine previously. |
Let's target the release tomorrow. |
.github/workflows/release.yaml
Outdated
- name: Get folders with tests | ||
id: get-folders | ||
run: | | ||
FOLDERS=$(find . -maxdepth 2 -type d -name 'tests' ! -path '*/distutils/*' \ | ||
| cut -d "/" -f2 | sort -u \ | ||
| jq -Rsc 'split("\n") | map( select(length > 0) )') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Get folders with tests | |
id: get-folders | |
run: | | |
FOLDERS=$(find . -maxdepth 2 -type d -name 'tests' ! -path '*/distutils/*' \ | |
| cut -d "/" -f2 | sort -u \ | |
| jq -Rsc 'split("\n") | map( select(length > 0) )') | |
- name: Set up Python | |
uses: actions/setup-python@v5 | |
with: | |
python-version: "3.13" | |
check-latest: true | |
- name: Get folders with tests | |
id: get-folders | |
run: | | |
pip install -U pip -r requirements_test.txt | |
FOLDERS=$(python scripts/helper.py list-test-folders --exclude distutils) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! I did a quite more extensive test on my fork and the release was created successfully with all artifacts uploaded.
If you have configured Trusted Publisher in PyPI, I'd say go for it!
.github/workflows/release.yaml
Outdated
push: | ||
tags: | ||
- '*' | ||
pull_request: # FIXME: temporary until release.yaml works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pull_request: # FIXME: temporary until release.yaml works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to configure many packages in this repository for trusted publisher. I am trying to set token
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And thank you so much. This is my first time to setup PyPI release by workflow. It must had taken a lot more time without your help.
Co-authored-by: Marc Mueller <[email protected]>
The release action: https://github.com/youknowone/python-deadlib/actions/runs/11597133339 |
Saw it just know. Unfortunately there is a small issue with |
I am not sure but I messed up something. it was actually released in https://github.com/youknowone/python-deadlib/actions/runs/11596984318/job/32289460524 And yeah, chunk doesn't have tests 😂 |
Would have been too easy if it worked the first time 😄 Opened #38. |
@cdce8p @lucas42 Thank you so much, it would take a lot more time without your helps. Please tell me if anyone of here be interested in this project ownership. Due to the project's motivation, I am a bit concerned about being the sole owner. I’d love to share the responsibilities or even donate it to the Python or PyPA organizations one day, but based on PEP 594, that doesn’t seem likely to happen soon, if ever. |
@youknowone Yay, that's an amazing milestone! 🎉 It's been great working with you on this up until now. But I don't think I've much to contribute after this point. I'm not an expert in what any of these libraries are doing internally. I wish you all the best in future endeavours! 🙇 |
I'm in the same category as @lucas42 here, unfortunately. While I'm able to help out from time to time, my main intention was to get "a" working backport lib going so I can update another project for Python 3.13. |
Thank you for the replies. Yes, I will try to keep them up for a while, though I am not a kind of Python code writer anymore 😂 |
Would it be ok? @lucas42 @cdce8p
distutils is not included because its test does not pass on 3.13