-
-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notes support #653
Open
HookedBehemoth
wants to merge
26
commits into
zedeus:master
Choose a base branch
from
HookedBehemoth:feature-notes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Notes support #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HookedBehemoth
force-pushed
the
feature-notes
branch
2 times, most recently
from
June 28, 2022 13:01
76c930e
to
63bb30e
Compare
zedeus
requested changes
Jun 29, 2022
zedeus
reviewed
Jul 1, 2022
Should I bump the style sheet version parameter? |
Yes, it invalidates the browser cache |
girlbossceo
added a commit
to girlbossceo/nitter
that referenced
this pull request
Dec 21, 2022
Signed-off-by: r3g_5z <[email protected]>
girlbossceo
added a commit
to girlbossceo/nitter
that referenced
this pull request
Jan 21, 2023
Signed-off-by: r3g_5z <[email protected]>
this resolves the issue of badly sized iframes and lowers the amount of requests per client
HookedBehemoth
force-pushed
the
feature-notes
branch
from
April 23, 2023 19:25
7f3426c
to
4b2c8bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #646
My first draft so far with a few issues here and there to fix:
blockquote.twitter-tweet
embeds #586 (comment)) (out of scope; directly embedding requires multiple requests)alt text on images isn't setNot implemented (yet):
*https://twitter.com/i/notes/1539382544856035328
**https://twitter.com/i/notes/1539522210976698373
Some screenshots
(1)
(2)