fixed bug that caused some retweets to be rendered incorrectly #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s starting with the text "RT @"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some retweets have been truncated and displayed as "regular tweets" from the retweeter instead of a proper retweet.
In these cases the tweet message started with "RT @original_tweeter_handle".
Apparently there is a "tweet" element between the "legacy" and the "retweeted_status_result"."result" element sometimes. The "result" has the "__typename" "TweetWithVisibilityResults" when that is the case. Otherwise "__typename" is just "Tweet".
This might only be related to authentication based instances as this is where I have observed this kind of behaviors. But it might not be limited to it.
It looks like this kind of behaviour has already been observed and handled in a different spot in the nitter code base but unfortunately this check does not catch this case yet.