Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable Draft support in the prebuild binaries #664

Closed
wants to merge 1 commit into from
Closed

feat: enable Draft support in the prebuild binaries #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
cpp_arch: x64

env:
npm_config_zmq_draft: false
npm_config_zmq_draft: true
npm_config_zmq_shared: false
npm_config_arch: ${{ matrix.node_arch }}
npm_config_target_arch: ${{ matrix.node_arch }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
cpp_arch:
- x64
env:
npm_config_zmq_draft: false
npm_config_zmq_draft: true
npm_config_zmq_shared: false
npm_config_arch: ${{ matrix.node_arch }}
npm_config_target_arch: ${{ matrix.node_arch }}
Expand Down
2 changes: 1 addition & 1 deletion binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
'variables': {
'zmq_shared%': 'false',
'zmq_draft%': 'false',
'zmq_draft%': 'true',
'zmq_no_sync_resolve%': 'false',
'sanitizers%': 'false',
'openssl_fips': '',
Expand Down
2 changes: 1 addition & 1 deletion script/build.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion script/build.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type Options = {
function parseOptions(): Options {
return {
zmq_shared: toBool(process.env.npm_config_zmq_shared) ?? false,
zmq_draft: toBool(process.env.npm_config_zmq_draft) ?? false,
zmq_draft: toBool(process.env.npm_config_zmq_draft) ?? true,
zmq_version:
toString(process.env.npm_config_zmq_version) ??
"5657b4586f24ec433930e8ece02ddba7afcf0fe0",
Expand Down
Loading