nextcloud-client: fix dbus service location

[kleifgch]

I see no reason, why this service file would be placed in a location where dbus does not expect it.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[kleifgch]

@Ma27 you seem to have written the original patch.
Maybe you can tell me if I missed something.

[lucasew]

Isn't this a no-op? Isn't the build system using the value provided by pkg-config? If this solves the issue, did you try to upstream the patch?

[lucasew]

I answered my two questions by simply building the package on master.

The issue is there.

[lucasew]

Upstream changed a little this logic. Probably it will be solved in the next bump.

I didn't know one could pass a variable to override a value in pkg-config tho

https://github.com/nextcloud/desktop/blob/ef1d2a34cc0bbc6e5c7631648c89c6665c9e6fc0/shell_integration/libcloudproviders/CMakeLists.txt#L3

[lucasew]

Latest version rn is 3.15.2 tho

[kleifgch]

Thanks for your comments!
I did not previously think about that change in upstream, but you're right that it is relevant.
That change is 8 months old and has landed well before the 3.14.3 that is currently in nixpkgs.
That has not fixed the problem yet, because the applied path explicitly overrides that again.
I just tried removing the patch entirely and the service indeed gets installed correctly now,
so this is probably the best solution.

[kleifgch]

@lucasew Would you mind taking another look?

[lucasew]

I'm cherry-picking this to my branch to test

I'm updating the package, I hope it doesn't conflict. If the stuff is in services instead of service then LGTM.

#368914

[lucasew]

For context:

• This package is emiting the dbus services into $out/share/dbus-1/service
• It should emit into $out/share/dbus-1/services as you can check in /run/current-system/sw

[lucasew]

Nice

[GaetanLepage]

Diff LGTM ^^

[GaetanLepage]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368873

---

x86_64-linux

✅ 2 packages built:

• nextcloud-client
• nextcloud-client.dev

---

aarch64-linux

✅ 2 packages built:

• nextcloud-client
• nextcloud-client.dev