Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud-client: 3.14.3 -> 3.15.2, to by-name, minor tweaks #368914

Merged
merged 3 commits into from
Dec 28, 2024

Conversation

lucasew
Copy link
Contributor

@lucasew lucasew commented Dec 28, 2024

Depends on: #368873

  • nextcloud-client: move to by-name, tweak
  • nextcloud-client: 3.14.3 -> 3.15.2
  • nextcloud-client: add libsysprof-capture to dependencies as asked by the build system

image

When I stopped and reopened it it asked to authenticate again.

Tested with my Nextcloud 29 instance.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 28, 2024
@lucasew lucasew marked this pull request as ready for review December 28, 2024 20:21
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 368914


x86_64-linux

✅ 2 packages built:
  • nextcloud-client
  • nextcloud-client.dev

aarch64-linux

✅ 2 packages built:
  • nextcloud-client
  • nextcloud-client.dev

@GaetanLepage GaetanLepage merged commit 0d7cc71 into NixOS:master Dec 28, 2024
23 of 24 checks passed
@lucasew lucasew deleted the 20241228-nextcloud-client branch December 30, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants