chore(packaging): Fix computing SCM-based version @ the dists #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously existing attempt to use `setuptools-git-version` never worked as it wasn't integrated correctly — it was added as a runtime dependency while it's meant to be a build dependency. This resulted in 0.0.0 being used all the time. This patch adds a hatchling plugin that implements the original idea in a way that actually works.
MaxymVlasov
changed the title
MaxymVlasov
approved these changes
Dec 28, 2024
webknjaz
added a commit
to webknjaz/antonbabenko--pre-commit-terraform
that referenced
this pull request
Dec 28, 2024
It's a follow-up to antonbabenko#735 that lacks this property. It's also an internal change. It essentially allows one to ``` $ pip install https://github.com/antonbabenko/pre-commit-terraform/archive/ae5057d.zip ``` and get a correctly computed version in the installed metadata. [1]: https://setuptools-scm.rtfd.io/en/latest/usage/#git-archives
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previously existing attempt to use
setuptools-git-versionnever worked as it wasn't integrated correctly — it was added as a runtime dependency while it's meant to be a build dependency. This resulted in 0.0.0 being used all the time.This patch adds a hatchling plugin that implements the original idea in a way that actually works.
Put an
xinto the box if that apply:Description of your changes
$sbj.
How can we test changes
python -Im build