Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RatisConsensus] enforce the newly added peer have different endpoint #14517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SzyWilliam
Copy link
Member

Enforce the user to use RatisConsensus correctly.

@MiniSho
Copy link
Contributor

MiniSho commented Dec 24, 2024

Thanks for your contributions to IoTDB!
* .  * .' * ★ *  '*   *
*  . '  +:..:+   '  '  *
.   *  ☆☆☆ *   .
  *  ' +:...+....:+  *
'    ' ☆☆☆☆☆   * '  
 * * ' +:...:+@+:...:+    '  *
* .  .☆☆☆☆☆☆☆ * ' * .
  .  +:..:+&+:...:+:...:+
 * . ☆☆☆☆☆☆☆☆☆ * '   *
' .  +:...:+♡+:...:+§+:..:+
. * ☆☆☆☆☆☆☆☆☆☆☆  ' *
  .+:..:+♡+:..:+@+:..:+♡+:..:+
 .     . ▨   ' ' *     
(¸*♥Merry Christmas♥〃´`)

@@ -555,6 +555,13 @@ public void addRemotePeer(ConsensusGroupId groupId, Peer peer) throws ConsensusE
throw new PeerAlreadyInConsensusGroupException(groupId, peer);
}

// pre-condition: peer should not have same ip address with any member already in the group
if (group.getPeers().stream()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combine to line 554?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants