Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RatisConsensus] enforce the newly added peer have different endpoint #14517

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[RatisConsensus] enforce the newly added peer have different endpoint #14517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/ratis/RatisConsensus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,13 @@ public void addRemotePeer(ConsensusGroupId groupId, Peer peer) throws ConsensusE
throw new PeerAlreadyInConsensusGroupException(groupId, peer);
}

// pre-condition: peer should not have same ip address with any member already in the group
if (group.getPeers().stream()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combine to line 554?

.anyMatch(
p -> Utils.fromRaftPeerAddressToTEndPoint(p.getAddress()).equals(peer.getEndpoint()))) {
throw new PeerAlreadyInConsensusGroupException(groupId, peer);
}

List<RaftPeer> newConfig = new ArrayList<>(group.getPeers());
newConfig.add(peerToAdd);

Expand Down
Loading