[release/9.0-staging] Fix to #35239 - EF9: SaveChanges() is significantly slower in .NET9 vs. .NET8 when using .ToJson() Mapping vs. PostgreSQL Legacy POCO mapping #35360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
changed the title
…s. .NET8 when using .ToJson() Mapping vs. PostgreSQL Legacy POCO mapping
AndriySvyryd
approved these changes
Dec 20, 2024
|
@AndriySvyryd update: added changes to the cosmos StringDictionaryComparer. It does support nested collections and the legacy functions can be invoked (rather than just being constructed like in relational). I added targeted fix similar to what I initially did for main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Less risky version of the #35326 for patch. If the type TElement type arguments match between element comparer and list comparer, we pass the Equals/Snapshot/Hashcode lambas from element to the list comparer method. Otherwise we fallback to the legacy code, which we know works but constructs redundant comparer objects (perf problem). This is not a real issue however - in reality the legacy code would only be invoked for nested collection scenarios and these are not supported (outside of InMemory). All we really need to do is to construct some Equals, Snapshot and Hashcode expressions (and not throw in the process)
Fixes #35239